SpotBugs Bug Detector Report
The following document contains the results of SpotBugs
SpotBugs Version is 4.8.6
Threshold is medium
Effort is default
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 180 |
22 |
0 |
0 |
lib.aide.resource.content.ResourceFactory$SuffixedResourceFactory
| Bug |
Category |
Details |
Line |
Priority |
lib.aide.tabular.JooqRowsSupplier
| Bug |
Category |
Details |
Line |
Priority |
| Switch statement found in lib.aide.tabular.JooqRowsSupplier.query() where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
221 |
Medium |
lib.aide.vfs.VfsIngressConsumer
| Bug |
Category |
Details |
Line |
Priority |
| Exception is caught when Exception is not thrown in lib.aide.vfs.VfsIngressConsumer.consumeUnzipped(VfsIngressConsumer$IngressIndividual, FileObject, FileObject, VfsIngressConsumer$Audit) |
STYLE |
REC_CATCH_EXCEPTION |
408 |
Medium |
org.diabetestechnology.drh.conf.Configuration
| Bug |
Category |
Details |
Line |
Priority |
| Redundant nullcheck of resolvedPropertyName, which is known to be non-null in org.diabetestechnology.drh.conf.Configuration.checkProperties(Environment, String[]) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
65 |
Medium |
org.diabetestechnology.drh.service.http.SwaggerConfig
| Bug |
Category |
Details |
Line |
Priority |
| Format string should use %n rather than \n in org.diabetestechnology.drh.service.http.SwaggerConfig.lambda$customGlobalHeaders$0(Operation, HandlerMethod) |
BAD_PRACTICE |
VA_FORMAT_STRING_USES_NEWLINE |
69 |
Medium |
| Format string should use %n rather than \n in org.diabetestechnology.drh.service.http.SwaggerConfig.lambda$customGlobalHeaders$0(Operation, HandlerMethod) |
BAD_PRACTICE |
VA_FORMAT_STRING_USES_NEWLINE |
46 |
Medium |
org.diabetestechnology.drh.service.http.aggrid.NumberColumnFilter
| Bug |
Category |
Details |
Line |
Priority |
org.diabetestechnology.drh.service.http.aggrid.ServerRowsRequest
| Bug |
Category |
Details |
Line |
Priority |
| Class org.diabetestechnology.drh.service.http.aggrid.ServerRowsRequest defines non-transient non-serializable instance field filterModel |
BAD_PRACTICE |
SE_BAD_FIELD |
|
Medium |
org.diabetestechnology.drh.service.http.hub.prime.service.CombineDataAccessService
| Bug |
Category |
Details |
Line |
Priority |
| Redundant nullcheck of response, which is known to be non-null in org.diabetestechnology.drh.service.http.hub.prime.service.CombineDataAccessService.getCohortReport(CohortRequest) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
239 |
Medium |
| Redundant nullcheck of response, which is known to be non-null in org.diabetestechnology.drh.service.http.hub.prime.service.CombineDataAccessService.getCohortReport(CohortRequest) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
205 |
Medium |
org.diabetestechnology.drh.service.http.hub.prime.service.DataAccessService
| Bug |
Category |
Details |
Line |
Priority |
| Sequence of calls to java.util.concurrent.ConcurrentHashMap may not be atomic in org.diabetestechnology.drh.service.http.hub.prime.service.DataAccessService.attachDatabase(String, String) |
MT_CORRECTNESS |
AT_OPERATION_SEQUENCE_ON_CONCURRENT_ABSTRACTION |
153 |
Medium |
| Found reliance on default encoding in org.diabetestechnology.drh.service.http.hub.prime.service.DataAccessService.createViews(String): new java.io.FileReader(String) |
I18N |
DM_DEFAULT_ENCODING |
2262 |
High |
| Redundant nullcheck of Double.toString(), which is known to be non-null in org.diabetestechnology.drh.service.http.hub.prime.service.DataAccessService.lambda$calculateMValue$22(String, String, String, String) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
1184 |
Medium |
| Redundant nullcheck of result, which is known to be non-null in org.diabetestechnology.drh.service.http.hub.prime.service.DataAccessService.lambda$getDailyGlucoseProfile$39(String, String, String, String) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
2333 |
Medium |
| Redundant nullcheck of result, which is known to be non-null in org.diabetestechnology.drh.service.http.hub.prime.service.DataAccessService.lambda$liabilityIndex$20(String, String, String, String) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
1021 |
Medium |
| org.diabetestechnology.drh.service.http.hub.prime.service.DataAccessService.attachDatabase(String, String) calls Thread.sleep() with a lock held |
MT_CORRECTNESS |
SWL_SLEEP_WITH_LOCK_HELD |
167 |
Medium |
org.diabetestechnology.drh.service.http.hub.prime.ux.ParticipantController
| Bug |
Category |
Details |
Line |
Priority |
| The method name org.diabetestechnology.drh.service.http.hub.prime.ux.ParticipantController.AmbulatoryGlucoseProfile(String, String, String, String) doesn't start with a lower case letter |
BAD_PRACTICE |
NM_METHOD_NAMING_CONVENTION |
240 |
Medium |
| The method name org.diabetestechnology.drh.service.http.hub.prime.ux.ParticipantController.CoefficientOfVariation(String, String, String, String) doesn't start with a lower case letter |
BAD_PRACTICE |
NM_METHOD_NAMING_CONVENTION |
213 |
Medium |
org.diabetestechnology.drh.service.http.hub.prime.ux.StudyVanityMatricsController
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference of studyId in org.diabetestechnology.drh.service.http.hub.prime.ux.StudyVanityMatricsController.getStudyCGMFileNames(String, TabularRowsRequest, boolean, boolean) |
CORRECTNESS |
NP_NULL_ON_SOME_PATH |
405 |
Medium |
| Possible null pointer dereference of studyId in org.diabetestechnology.drh.service.http.hub.prime.ux.StudyVanityMatricsController.getStudyCGMFiles(String, String, TabularRowsRequest, boolean, boolean) |
CORRECTNESS |
NP_NULL_ON_SOME_PATH |
429 |
Medium |
org.diabetestechnology.drh.service.http.util.JsonText$ByteArrayToStringOrJsonSerializer
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in org.diabetestechnology.drh.service.http.util.JsonText$ByteArrayToStringOrJsonSerializer.serialize(byte[], JsonGenerator, SerializerProvider): new String(byte[]) |
I18N |
DM_DEFAULT_ENCODING |
214 |
High |
org.diabetestechnology.drh.service.http.util.MetricsQueries
| Bug |
Category |
Details |
Line |
Priority |
| org.diabetestechnology.drh.service.http.util.MetricsQueries.combined_all_metrics is initialized to a string constant 6686 characters long that is duplicated in 2 other class files |
PERFORMANCE |
HSC_HUGE_SHARED_STRING_CONSTANT |
|
Medium |
