SpotBugs Bug Detector Report
The following document contains the results of SpotBugs
SpotBugs Version is 4.9.2
Threshold is medium
Effort is default
Summary
| Classes | Bugs | Errors | Missing Classes |
|---|---|---|---|
| 371 | 154 | 0 | 0 |
Files
lib.aide.resource.content.ResourceFactory$SuffixedResourceFactory
| Bug | Category | Details | Line | Priority |
|---|
lib.aide.tabular.JooqRowsSupplier
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Switch statement found in lib.aide.tabular.JooqRowsSupplier.query() where default case is missing | STYLE | SF_SWITCH_NO_DEFAULT | 232 | Medium |
lib.aide.vfs.VfsIngressConsumer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in lib.aide.vfs.VfsIngressConsumer.consumeUnzipped(VfsIngressConsumer$IngressIndividual, FileObject, FileObject, VfsIngressConsumer$Audit) | STYLE | REC_CATCH_EXCEPTION | 408 | Medium |
org.diabetestechnology.drh.conf.Configuration
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of resolvedPropertyName, which is known to be non-null in org.diabetestechnology.drh.conf.Configuration.checkProperties(Environment, String[]) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 65 | Medium |
org.diabetestechnology.drh.service.http.GitHubUserAuthorizationFilter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.diabetestechnology.drh.service.http.GitHubUserAuthorizationFilter.doFilterInternal(HttpServletRequest, HttpServletResponse, FilterChain) | STYLE | REC_CATCH_EXCEPTION | 181 | Medium |
| Useless object stored in variable attributes of method org.diabetestechnology.drh.service.http.GitHubUserAuthorizationFilter.doFilterInternal(HttpServletRequest, HttpServletResponse, FilterChain) | STYLE | UC_USELESS_OBJECT | 130 | Medium |
org.diabetestechnology.drh.service.http.OauthUsersService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.OauthUsersService.isAuthorizedUserDB(DefaultOAuth2User) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 79 | Medium |
org.diabetestechnology.drh.service.http.SwaggerConfig
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Format string should use %n rather than \n in org.diabetestechnology.drh.service.http.SwaggerConfig.lambda$customGlobalHeaders$0(Operation, HandlerMethod) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 69 | Medium |
| Format string should use %n rather than \n in org.diabetestechnology.drh.service.http.SwaggerConfig.lambda$customGlobalHeaders$0(Operation, HandlerMethod) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 46 | Medium |
org.diabetestechnology.drh.service.http.aggrid.NumberColumnFilter
| Bug | Category | Details | Line | Priority |
|---|
org.diabetestechnology.drh.service.http.aggrid.ServerRowsRequest
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Class org.diabetestechnology.drh.service.http.aggrid.ServerRowsRequest defines non-transient non-serializable instance field filterModel | BAD_PRACTICE | SE_BAD_FIELD | Medium |
org.diabetestechnology.drh.service.http.hub.prime.ObservabilityRequestFilter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.diabetestechnology.drh.service.http.hub.prime.ObservabilityRequestFilter.uniqueSession isn't final and cannot be protected from malicious code | MALICIOUS_CODE | MS_CANNOT_BE_FINAL | 39 | Medium |
| Primitive field org.diabetestechnology.drh.service.http.hub.prime.ObservabilityRequestFilter.uniqueSession is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility. | BAD_PRACTICE | PA_PUBLIC_PRIMITIVE_ATTRIBUTE | 39 | Medium |
| Exception is caught when Exception is not thrown in org.diabetestechnology.drh.service.http.hub.prime.ObservabilityRequestFilter.doFilterInternal(HttpServletRequest, HttpServletResponse, FilterChain) | STYLE | REC_CATCH_EXCEPTION | 104 | Medium |
| Write to static field org.diabetestechnology.drh.service.http.hub.prime.ObservabilityRequestFilter.uniqueSession from instance method org.diabetestechnology.drh.service.http.hub.prime.ObservabilityRequestFilter.getUniqueSession(String, ContentCachingRequestWrapper) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 132 | Medium |
org.diabetestechnology.drh.service.http.hub.prime.service.CombineDataAccessService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of response, which is known to be non-null in org.diabetestechnology.drh.service.http.hub.prime.service.CombineDataAccessService.getCohortReport(CohortRequest) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 223 | Medium |
| Redundant nullcheck of response, which is known to be non-null in org.diabetestechnology.drh.service.http.hub.prime.service.CombineDataAccessService.getCohortReport(CohortRequest) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 189 | Medium |
org.diabetestechnology.drh.service.http.hub.prime.service.DataAccessService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Sequence of calls to java.util.concurrent.ConcurrentHashMap may not be atomic in org.diabetestechnology.drh.service.http.hub.prime.service.DataAccessService.attachDatabase(String, String) | MT_CORRECTNESS | AT_OPERATION_SEQUENCE_ON_CONCURRENT_ABSTRACTION | 151 | Medium |
| Redundant nullcheck of Double.toString(), which is known to be non-null in org.diabetestechnology.drh.service.http.hub.prime.service.DataAccessService.lambda$calculateMValue$22(String, String, String, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 1159 | Medium |
| Redundant nullcheck of nullResults, which is known to be non-null in org.diabetestechnology.drh.service.http.hub.prime.service.DataAccessService.lambda$computeAllMetrics$37(String, String, String, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 2174 | Medium |
| Redundant nullcheck of result, which is known to be non-null in org.diabetestechnology.drh.service.http.hub.prime.service.DataAccessService.lambda$computeAllMetrics$37(String, String, String, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 2180 | Medium |
| Redundant nullcheck of result, which is known to be non-null in org.diabetestechnology.drh.service.http.hub.prime.service.DataAccessService.lambda$getDailyGlucoseProfile$39(String, String, String, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 2244 | Medium |
| Redundant nullcheck of result, which is known to be non-null in org.diabetestechnology.drh.service.http.hub.prime.service.DataAccessService.lambda$getParticipantInfo$6(String, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 401 | Medium |
| Redundant nullcheck of result, which is known to be non-null in org.diabetestechnology.drh.service.http.hub.prime.service.DataAccessService.lambda$getParticipantMetrics$29(String, String, String, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 1565 | Medium |
| Redundant nullcheck of result, which is known to be non-null in org.diabetestechnology.drh.service.http.hub.prime.service.DataAccessService.lambda$getTimeRangeStackedData$30(String, String, String, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 1614 | Medium |
| Redundant nullcheck of result, which is known to be non-null in org.diabetestechnology.drh.service.http.hub.prime.service.DataAccessService.lambda$glycemicRiskIndicator$19(String, String, String, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 938 | Medium |
| Redundant nullcheck of result, which is known to be non-null in org.diabetestechnology.drh.service.http.hub.prime.service.DataAccessService.lambda$liabilityIndex$20(String, String, String, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 1002 | Medium |
| org.diabetestechnology.drh.service.http.hub.prime.service.DataAccessService.attachDatabase(String, String) calls Thread.sleep() with a lock held | MT_CORRECTNESS | SWL_SLEEP_WITH_LOCK_HELD | 165 | Medium |
| Useless object stored in variable noDataMap of method org.diabetestechnology.drh.service.http.hub.prime.service.DataAccessService.lambda$getParticipantCGMDates$2(String, String) | STYLE | UC_USELESS_OBJECT | 227 | Medium |
org.diabetestechnology.drh.service.http.hub.prime.service.VannaAI.AIService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.diabetestechnology.drh.service.http.hub.prime.service.VannaAI.AIService.alias; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 33 | Medium |
org.diabetestechnology.drh.service.http.hub.prime.service.cohortFilter.CohortFilterService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of cohortFilters, which is known to be non-null in org.diabetestechnology.drh.service.http.hub.prime.service.cohortFilter.CohortFilterService.getCohortFilter() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 168 | Medium |
| Unread field: org.diabetestechnology.drh.service.http.hub.prime.service.cohortFilter.CohortFilterService.alias; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 35 | Medium |
org.diabetestechnology.drh.service.http.hub.prime.service.interaction.ActivityLogService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Unread field: org.diabetestechnology.drh.service.http.hub.prime.service.interaction.ActivityLogService.alias; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 47 | Medium |
org.diabetestechnology.drh.service.http.hub.prime.service.interaction.AuditService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The method name org.diabetestechnology.drh.service.http.hub.prime.service.interaction.AuditService.FormatActivityDataResponse(List) doesn't start with a lower case letter | BAD_PRACTICE | NM_METHOD_NAMING_CONVENTION | 42 | Medium |
org.diabetestechnology.drh.service.http.hub.prime.ux.OrcidUserController
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.hub.prime.ux.OrcidUserController.getOrcidUserFormatedInfo(String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 314 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.hub.prime.ux.OrcidUserController.getOrcidUserFormatedInfo(String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 315 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.hub.prime.ux.OrcidUserController.getOrcidUserFormatedInfo(String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 316 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.hub.prime.ux.OrcidUserController.getUserInfo() due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 74 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.hub.prime.ux.OrcidUserController.getUserInfo() due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 75 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.hub.prime.ux.OrcidUserController.getUserInfo() due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 76 | Medium |
org.diabetestechnology.drh.service.http.hub.prime.ux.Presentation
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of authentication at line 49 of value previously dereferenced in org.diabetestechnology.drh.service.http.hub.prime.ux.Presentation.isAuthenticatedUser() | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 49 | Medium |
org.diabetestechnology.drh.service.http.hub.prime.ux.TabularRowsController
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.diabetestechnology.drh.service.http.hub.prime.ux.TabularRowsController.createSortCondition(List, JooqRowsSupplier$TypableTable) may return null, but is declared @Nonnull | CORRECTNESS | NP_NONNULL_RETURN_VIOLATION | 192 | High |
| Redundant nullcheck of finalCondition, which is known to be non-null in org.diabetestechnology.drh.service.http.hub.prime.ux.TabularRowsController.customDashboardTabularRows(TabularRowsRequest, boolean, boolean) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 242 | Medium |
org.diabetestechnology.drh.service.http.hub.prime.ux.TabularRowsControllerCustom
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.diabetestechnology.drh.service.http.hub.prime.ux.TabularRowsControllerCustom.createSortCondition(List, JooqRowsSupplier$TypableTable) may return null, but is declared @Nonnull | CORRECTNESS | NP_NONNULL_RETURN_VIOLATION | 660 | High |
| Redundant nullcheck of finalCondition, which is known to be non-null in org.diabetestechnology.drh.service.http.hub.prime.ux.TabularRowsControllerCustom.customPopulationTabularRows(TabularRowsRequest, boolean, boolean) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 813 | Medium |
org.diabetestechnology.drh.service.http.pg.filter.CustomTabularFilter
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.diabetestechnology.drh.service.http.pg.filter.CustomTabularFilter.createSortCondition(List, JooqRowsSupplier$TypableTable) may return null, but is declared @Nonnull | CORRECTNESS | NP_NONNULL_RETURN_VIOLATION | 112 | High |
org.diabetestechnology.drh.service.http.pg.service.AuthUserDetailsService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.AuthUserDetailsService.isSuperAdmin() due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 81 | Medium |
org.diabetestechnology.drh.service.http.pg.service.CgmMasterService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.CgmMasterService.getCgmDevicesList(String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 57 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.CgmMasterService.getSourcePlatformList() due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 34 | Medium |
org.diabetestechnology.drh.service.http.pg.service.ChunkDatabaseMigrationService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to hierarchyJsonArray in org.diabetestechnology.drh.service.http.pg.service.ChunkDatabaseMigrationService.migrateDatabase(String, String, String, JSONB, String, DatabaseMigrationRequest, String, String, String, String, String, List, String) | STYLE | DLS_DEAD_LOCAL_STORE | 682 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.ChunkDatabaseMigrationService.copyTablesFromSqLiteToPostgres(String, String, String, JSONB, DSLContext, String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 559 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.ChunkDatabaseMigrationService.copyTablesFromSqLiteToPostgres(String, String, String, JSONB, DSLContext, String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 569 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.ChunkDatabaseMigrationService.isDatabaseAttached(String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 524 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.ChunkDatabaseMigrationService.mealsOrFitnessExists(String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 461 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.ChunkDatabaseMigrationService.migrateDatabase(String, String, String, JSONB, String, DatabaseMigrationRequest, String, String, String, String, String, List, String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 641 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.ChunkDatabaseMigrationService.migrateDatabase(String, String, String, JSONB, String, DatabaseMigrationRequest, String, String, String, String, String, List, String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 665 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.ChunkDatabaseMigrationService.migrateDatabase(String, String, String, JSONB, String, DatabaseMigrationRequest, String, String, String, String, String, List, String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 733 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.ChunkDatabaseMigrationService.startExtraction(String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 1225 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.ChunkDatabaseMigrationService.startExtraction(String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 1181 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.ChunkDatabaseMigrationService.startExtraction(String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 1099 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.ChunkDatabaseMigrationService.startExtraction(String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 1124 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.ChunkDatabaseMigrationService.startExtraction(String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 1149 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.ChunkDatabaseMigrationService.startExtraction(String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 1193 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.ChunkDatabaseMigrationService.startExtraction(String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 1238 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.ChunkDatabaseMigrationService.uploadAndSaveDBFile(String, DatabaseMigrationRequest, long, String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 126 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.ChunkDatabaseMigrationService.validateFileMetaIngestData(String, DSLContext) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 971 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.ChunkDatabaseMigrationService.validateFileMetaIngestData(String, DSLContext) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 986 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.ChunkDatabaseMigrationService.validateFileMetaIngestData(String, DSLContext) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 1001 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.ChunkDatabaseMigrationService.validateFileMetaIngestData(String, DSLContext) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 1017 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.ChunkDatabaseMigrationService.validateParticipantData(String, DSLContext) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 863 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.ChunkDatabaseMigrationService.validateParticipantMealFitnessData(String, DSLContext) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 886 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.ChunkDatabaseMigrationService.validateStudyMetaData(String, DSLContext) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 907 | Medium |
| Redundant nullcheck of fileURL, which is known to be non-null in org.diabetestechnology.drh.service.http.pg.service.ChunkDatabaseMigrationService.uploadAndSaveDBFile(String, DatabaseMigrationRequest, long, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 156 | Medium |
| Redundant nullcheck of hierarchyJsonArray, which is known to be non-null in org.diabetestechnology.drh.service.http.pg.service.ChunkDatabaseMigrationService.uploadAndSaveDBFile(String, DatabaseMigrationRequest, long, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 265 | Medium |
| Exception is caught when Exception is not thrown in org.diabetestechnology.drh.service.http.pg.service.ChunkDatabaseMigrationService.migrateDatabase(String, String, String, JSONB, String, DatabaseMigrationRequest, String, String, String, String, String, List, String) | STYLE | REC_CATCH_EXCEPTION | 762 | Medium |
| Exception is caught when Exception is not thrown in org.diabetestechnology.drh.service.http.pg.service.ChunkDatabaseMigrationService.startExtraction(String) | STYLE | REC_CATCH_EXCEPTION | 1296 | Medium |
| Exception is caught when Exception is not thrown in org.diabetestechnology.drh.service.http.pg.service.ChunkDatabaseMigrationService.uploadAndSaveDBFile(String, DatabaseMigrationRequest, long, String) | STYLE | REC_CATCH_EXCEPTION | 431 | Medium |
| Exceptional return value of java.io.File.delete() ignored in org.diabetestechnology.drh.service.http.pg.service.ChunkDatabaseMigrationService.mergeChunks(String, int) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 955 | Medium |
| Unread field: org.diabetestechnology.drh.service.http.pg.service.ChunkDatabaseMigrationService.postgresDbName; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 62 | Medium |
org.diabetestechnology.drh.service.http.pg.service.DatabaseMigrationService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.DatabaseMigrationService.copyTablesFromSqLiteToPostgres(String, String, String, JSONB) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 216 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.DatabaseMigrationService.copyTablesFromSqLiteToPostgres(String, String, String, JSONB) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 226 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.DatabaseMigrationService.isDatabaseAttached(String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 181 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.DatabaseMigrationService.uploadAndSaveDBFile(MultipartFile, DatabaseMigrationRequest) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 103 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.DatabaseMigrationService.uploadAndSaveDBFile(MultipartFile, DatabaseMigrationRequest) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 107 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.DatabaseMigrationService.validateParticipantData(String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 405 | Medium |
| Redundant nullcheck of fileURL, which is known to be non-null in org.diabetestechnology.drh.service.http.pg.service.DatabaseMigrationService.uploadAndSaveDBFile(MultipartFile, DatabaseMigrationRequest) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 78 | Medium |
| Redundant nullcheck of tempFilePath, which is known to be non-null in org.diabetestechnology.drh.service.http.pg.service.DatabaseMigrationService.uploadAndSaveDBFile(MultipartFile, DatabaseMigrationRequest) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 92 | Medium |
| Unread field: org.diabetestechnology.drh.service.http.pg.service.DatabaseMigrationService.postgresDbName; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 41 | Medium |
| Unread field: org.diabetestechnology.drh.service.http.pg.service.DatabaseMigrationService.sqliteDbName; should this field be static? | PERFORMANCE | SS_SHOULD_BE_STATIC | 40 | Medium |
org.diabetestechnology.drh.service.http.pg.service.FileService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.FileService.extractHeaders(String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 44 | Medium |
org.diabetestechnology.drh.service.http.pg.service.InteractionService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.InteractionService.saveHubInteraction(String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 72 | Medium |
| Exception is caught when Exception is not thrown in org.diabetestechnology.drh.service.http.pg.service.InteractionService.saveFileInteraction(String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, String, int, String, List, String) | STYLE | REC_CATCH_EXCEPTION | 236 | Medium |
| Exception is caught when Exception is not thrown in org.diabetestechnology.drh.service.http.pg.service.InteractionService.saveStudyInteraction(String, String, String, String, String, String, String, String, String, int, String, String, String) | STYLE | REC_CATCH_EXCEPTION | 136 | Medium |
| Exception is caught when Exception is not thrown in org.diabetestechnology.drh.service.http.pg.service.InteractionService.saveStudyParticipantInteraction(String, String, String, String, String, String, String, String, String, String, int, String, String, String) | STYLE | REC_CATCH_EXCEPTION | 625 | Medium |
org.diabetestechnology.drh.service.http.pg.service.InvestigatorService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of jsonbResult, which is known to be non-null in org.diabetestechnology.drh.service.http.pg.service.InvestigatorService.getInvestigator() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 73 | High |
| Nullcheck of result at line 203 of value previously dereferenced in org.diabetestechnology.drh.service.http.pg.service.InvestigatorService.saveCollaborationTeam(InvestigatorRequest) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 203 | High |
org.diabetestechnology.drh.service.http.pg.service.MasterService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.MasterService.getActiontype(String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 580 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.MasterService.getInteractionStatus(String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 593 | Medium |
org.diabetestechnology.drh.service.http.pg.service.MealsAndFitnessService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.diabetestechnology.drh.service.http.pg.service.MealsAndFitnessService.saveMealsAndFitnessFile(MultipartFile, String, String, String, String) uses the same code for two branches | STYLE | DB_DUPLICATE_BRANCHES | 336 | Medium |
| org.diabetestechnology.drh.service.http.pg.service.MealsAndFitnessService.saveMealsAndFitnessFile(MultipartFile, String, String, String, String) uses the same code for two branches | STYLE | DB_DUPLICATE_BRANCHES | 346 | Medium |
| Redundant nullcheck of tempFilePath, which is known to be non-null in org.diabetestechnology.drh.service.http.pg.service.MealsAndFitnessService.saveMealsAndFitnessFile(MultipartFile, String, String, String, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 190 | Medium |
org.diabetestechnology.drh.service.http.pg.service.OrganizationService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.OrganizationService.saveOrganization(OrganizationRequest) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 60 | Medium |
org.diabetestechnology.drh.service.http.pg.service.ParticipantRowFileService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of tempFilePath, which is known to be non-null in org.diabetestechnology.drh.service.http.pg.service.ParticipantRowFileService.saveCgmRowFile(MultipartFile, String, String, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 161 | Medium |
| Exception is caught when Exception is not thrown in org.diabetestechnology.drh.service.http.pg.service.ParticipantRowFileService.prepareCgmRequestJson(ParticipantRowFileRequest, List, String) | STYLE | REC_CATCH_EXCEPTION | 472 | Medium |
org.diabetestechnology.drh.service.http.pg.service.ParticipantService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Load of known null value in org.diabetestechnology.drh.service.http.pg.service.ParticipantService.saveParticipantData(ParticipantDataRequest) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 144 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.ParticipantService.checkIfParticipantDisplayIdExists(String, String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 319 | Medium |
| Redundant nullcheck of result which is known to be null in org.diabetestechnology.drh.service.http.pg.service.ParticipantService.saveParticipantData(ParticipantDataRequest) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE | 144 | Medium |
| Exception is caught when Exception is not thrown in org.diabetestechnology.drh.service.http.pg.service.ParticipantService.saveParticipantData(ParticipantDataRequest) | STYLE | REC_CATCH_EXCEPTION | 149 | Medium |
| Exception is caught when Exception is not thrown in org.diabetestechnology.drh.service.http.pg.service.ParticipantService.updateParticipantData(String, ParticipantDataRequest) | STYLE | REC_CATCH_EXCEPTION | 445 | Medium |
| Exception is caught when Exception is not thrown in org.diabetestechnology.drh.service.http.pg.service.ParticipantService.updateParticipantDataInline(String, JSONB) | STYLE | REC_CATCH_EXCEPTION | 229 | Medium |
org.diabetestechnology.drh.service.http.pg.service.PractitionerService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.PractitionerService.isUniqueEmail(String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 405 | Medium |
org.diabetestechnology.drh.service.http.pg.service.PubMedService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in org.diabetestechnology.drh.service.http.pg.service.PubMedService.extractPubMedDetails(String): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 67 | High |
org.diabetestechnology.drh.service.http.pg.service.ResearchStudyParticipantFileService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in org.diabetestechnology.drh.service.http.pg.service.ResearchStudyParticipantFileService.convertToJsonArray(String): new java.io.FileReader(String) | I18N | DM_DEFAULT_ENCODING | 337 | High |
| Found reliance on default encoding in org.diabetestechnology.drh.service.http.pg.service.ResearchStudyParticipantFileService.generateParticipantFitnessCsvTemplate(): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 491 | High |
| Found reliance on default encoding in org.diabetestechnology.drh.service.http.pg.service.ResearchStudyParticipantFileService.generateParticipantMealsCsvTemplate(): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 480 | High |
| Found reliance on default encoding in org.diabetestechnology.drh.service.http.pg.service.ResearchStudyParticipantFileService.validateCsvFileField(MultipartFile): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 306 | High |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.ResearchStudyParticipantFileService.uploadAndSaveParticipantFile(MultipartFile, ParticipantFileDataRequest) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 72 | Medium |
| Redundant nullcheck of valid, which is known to be non-null in org.diabetestechnology.drh.service.http.pg.service.ResearchStudyParticipantFileService.uploadAndSaveParticipantFile(MultipartFile, ParticipantFileDataRequest) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 158 | Medium |
org.diabetestechnology.drh.service.http.pg.service.ResearchStudyService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.ResearchStudyService.checkStudyDisplayIdExists(String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 667 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.ResearchStudyService.deleteResearchStudy(String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 586 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.ResearchStudyService.editResearchStudyArchiveStatus(String, Boolean) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 393 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.ResearchStudyService.updatePublicationInline(String, PublicationUpdateRequest, String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 481 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.ResearchStudyService.updateVisibility(String, Integer) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 538 | Medium |
| Redundant nullcheck of jsonbResult, which is known to be non-null in org.diabetestechnology.drh.service.http.pg.service.ResearchStudyService.getInvestigatorOrAuthor(String, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 703 | High |
org.diabetestechnology.drh.service.http.pg.service.S3FileUploadService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in org.diabetestechnology.drh.service.http.pg.service.S3FileUploadService.convertCsvToJson(String): new java.io.FileReader(String) | I18N | DM_DEFAULT_ENCODING | 700 | High |
| Found reliance on default encoding in org.diabetestechnology.drh.service.http.pg.service.S3FileUploadService.generateCsvTemplate(): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 367 | High |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.S3FileUploadService.processContent(String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 431 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.S3FileUploadService.uploadCgmFile(MultipartFile, String, String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 293 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.S3FileUploadService.uploadDBFileToS3(MultipartFile, DatabaseMigrationRequest) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 655 | Medium |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.S3FileUploadService.uploadParticipantFileToS3Bucket(MultipartFile, String, String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 334 | Medium |
| Redundant nullcheck of age, which is known to be non-null in org.diabetestechnology.drh.service.http.pg.service.S3FileUploadService.validateParticipantFileJson(ArrayNode) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 251 | Medium |
| Redundant nullcheck of gender, which is known to be non-null in org.diabetestechnology.drh.service.http.pg.service.S3FileUploadService.validateParticipantFileJson(ArrayNode) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 267 | Medium |
| Exception is caught when Exception is not thrown in org.diabetestechnology.drh.service.http.pg.service.S3FileUploadService.parseExcelToJSONArray(byte[]) | STYLE | REC_CATCH_EXCEPTION | 581 | Medium |
| Exceptional return value of java.io.File.mkdirs() ignored in org.diabetestechnology.drh.service.http.pg.service.S3FileUploadService.saveFileToTempLocation(MultipartFile) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 210 | Medium |
org.diabetestechnology.drh.service.http.pg.service.SuperAdminService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.SuperAdminService.addSuperAdmin(String, String) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 89 | Medium |
org.diabetestechnology.drh.service.http.pg.service.UserRoleService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.pg.service.UserRoleService.updateUserRole(UserRoleRequest) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 213 | Medium |
org.diabetestechnology.drh.service.http.pg.service.email.OtpService
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Random object created and used only once in org.diabetestechnology.drh.service.http.pg.service.email.OtpService.generateAndSendOtp(String) | BAD_PRACTICE | DMI_RANDOM_USED_ONLY_ONCE | 16 | High |
org.diabetestechnology.drh.service.http.pg.ux.ChunkDatabaseMigrationController
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of String.toString(), which is known to be non-null in org.diabetestechnology.drh.service.http.pg.ux.ChunkDatabaseMigrationController.uploadDatabaseFile(MultipartFile, DatabaseMigrationRequest, int, int, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 67 | Medium |
org.diabetestechnology.drh.service.http.pg.ux.EmailController
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception is caught when Exception is not thrown in org.diabetestechnology.drh.service.http.pg.ux.EmailController.verifyOtp(OtpValidationRequest) | STYLE | REC_CATCH_EXCEPTION | 218 | Medium |
org.diabetestechnology.drh.service.http.pg.ux.OrganizationUserController
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of result, which is known to be non-null in org.diabetestechnology.drh.service.http.pg.ux.OrganizationUserController.saveOrganization(OrganizationRequest) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 50 | Medium |
org.diabetestechnology.drh.service.http.pg.ux.PractitionerController
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of resultObj, which is known to be non-null in org.diabetestechnology.drh.service.http.pg.ux.PractitionerController.getProfileDetails() | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 212 | Medium |
org.diabetestechnology.drh.service.http.pg.ux.ResearchStudyInvestigatorController
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Nullcheck of result at line 146 of value previously dereferenced in org.diabetestechnology.drh.service.http.pg.ux.ResearchStudyInvestigatorController.updateInvestigator(InvestigatorRequest) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 146 | High |
org.diabetestechnology.drh.service.http.pg.ux.TabularRowsStudyMealsOrFitnessInteractionControllerCustom
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.diabetestechnology.drh.service.http.pg.ux.TabularRowsStudyMealsOrFitnessInteractionControllerCustom.createSortCondition(List, JooqRowsSupplier$TypableTable) may return null, but is declared @Nonnull | CORRECTNESS | NP_NONNULL_RETURN_VIOLATION | 95 | High |
org.diabetestechnology.drh.service.http.pg.ux.TabularRowsStudyParticipantInteractionControllerCustom
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.diabetestechnology.drh.service.http.pg.ux.TabularRowsStudyParticipantInteractionControllerCustom.parentSuccessStudyParticipantInteraction(TabularRowsRequest, String, String, String, boolean, boolean) uses the same code for two branches | STYLE | DB_DUPLICATE_BRANCHES | 109 | Medium |
org.diabetestechnology.drh.service.http.pg.ux.TabularRowsUserSession
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to bindValues in org.diabetestechnology.drh.service.http.pg.ux.TabularRowsUserSession.distinctTabularAuditRows(TabularRowsRequest, boolean, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 53 | High |
| Dead store to $L9 in org.diabetestechnology.drh.service.http.pg.ux.TabularRowsUserSession.distinctTabularAuditRows(TabularRowsRequest, boolean, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 60 | Medium |
| Dead store to typableTable in org.diabetestechnology.drh.service.http.pg.ux.TabularRowsUserSession.distinctTabularAuditRows(TabularRowsRequest, boolean, boolean) | STYLE | DLS_DEAD_LOCAL_STORE | 50 | Medium |
org.diabetestechnology.drh.service.http.util.FileValidationUtil
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in org.diabetestechnology.drh.service.http.util.FileValidationUtil.validateTextFile(MultipartFile): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 54 | High |
| Possible null pointer dereference in org.diabetestechnology.drh.service.http.util.FileValidationUtil.validateExcelFile(MultipartFile) due to return value of called method | STYLE | NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE | 66 | Medium |
org.diabetestechnology.drh.service.http.util.JsonText$ByteArrayToStringOrJsonSerializer
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in org.diabetestechnology.drh.service.http.util.JsonText$ByteArrayToStringOrJsonSerializer.serialize(byte[], JsonGenerator, SerializerProvider): new String(byte[]) | I18N | DM_DEFAULT_ENCODING | 214 | High |
org.diabetestechnology.drh.service.http.util.MetricsQueries
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.diabetestechnology.drh.service.http.util.MetricsQueries.combined_all_metrics is initialized to a string constant 6686 characters long that is duplicated in 2 other class files | PERFORMANCE | HSC_HUGE_SHARED_STRING_CONSTANT | Medium |
org.diabetestechnology.drh.udi.CustomDataSource
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exception thrown in class org.diabetestechnology.drh.udi.CustomDataSource at new org.diabetestechnology.drh.udi.CustomDataSource(Consumer) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks. | BAD_PRACTICE | CT_CONSTRUCTOR_THROW | 85 | Medium |
| Exception thrown in class org.diabetestechnology.drh.udi.CustomDataSource at new org.diabetestechnology.drh.udi.CustomDataSource(CustomDataSource$Builder) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks. | BAD_PRACTICE | CT_CONSTRUCTOR_THROW | 81 | Medium |
org.diabetestechnology.drh.udi.UserContextConnectionProvider
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.diabetestechnology.drh.udi.UserContextConnectionProvider.acquire() passes a nonconstant String to an execute or addBatch method on an SQL statement | SECURITY | SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE | 60 | Medium |